fix(app-check): fix activate parameters and return, and app-check import advice #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue on some of my local build machines where ios won't build because node is not found
previously iOS was not returning a promise, but Android was, documentation was for a Promise to be returned Fixes #6052 - Thanks to @birdofpreyru
|
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4WQvuGu4J82wn3UtDhVZx7iSKBXq [Deployment for 8db97b4 failed] react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/hs8yvE8bBABkGz11xhas5iU4BrsC [Deployment for 8db97b4 canceled] |
Codecov Report
@@ Coverage Diff @@
## main #6056 +/- ##
=============================================
- Coverage 72.11% 52.96% -19.15%
- Complexity 0 623 +623
=============================================
Files 109 208 +99
Lines 4600 10205 +5605
Branches 1033 1623 +590
=============================================
+ Hits 3317 5404 +2087
- Misses 1205 4546 +3341
- Partials 78 255 +177 |
previously, the required string argument was not validated, and the optional boolean argument was not supplied to native, causing an android native crash if not supplied omitting the string now correctly throws an error, and omitting the token refresh boolean will default correctly to app check token refresh as configured in firebase.json, app-wide data collection if app check does not have a config, and the default true if there is no config Fixes #5981 - thanks to @rawatnaresh for catching this!
previously the error message for a missing import specified the camel-case version of the package name, which is right for the usage, but not for the import Fixes #6009 - thanks to @FakhruddinAbdi for noticing it!
mikehardy
force-pushed
the
@mikehardy/app-check-cleanup
branch
from
209f0d4
to
8db97b4
Compare
vercel
bot
temporarily deployed
to
Preview – react-native-firebase-next
mikehardy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up some issues in the app-check implementation
Related issues
Fixes #5981 where @rawatnaresh noticed we were not handling parameters correctly for activate
Fixes #6052 where @birdofpreyru noticed we were not returning correctly from activate on ios
Fixes #6009 where @FakhruddinAbdi noticed the error message we gave on app-check import missing was wrong
Release Summary
all conventional commits, rebase-merge --> release
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
I added e2e test cases to probe the failures noted by the people logging the issues in order to reproduce their problems, then repaired the code such that the e2e tests passed
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter